fix: break the watch loop when the watch fails

Otherwise the goroutine keeps spinning in the endless loop as `ch` gets closed on error and Stop(). Signed-off-by: Andrey Smirnov <[email protected]>
vmware-tanzu · Sep 25, 2023 · e9307f0 · e9307f0
1 parent 1efd8d7
commit e9307f0
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/client/logs.go b/pkg/client/logs.go
@@ -204,7 +204,11 @@ func watchPodsToStreamLogs(client kubernetes.Interface, cfg *LogConfig, podCh ch
 
 	go func() {
 		for {
-			v := <-ch
+			v, ok := <-ch
+			if !ok {
+				break
+			}
+
 			if v.Type == watch.Added && v.Object != nil {
 				switch t := v.Object.(type) {
 				case *v1.Pod: