Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cp Refine the security policy logic related with named port(#796) #831

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

timdengyun
Copy link
Contributor

CP PR: #796

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.59036% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.74%. Comparing base (58c18ae) to head (2da6fbb).

Files with missing lines Patch % Lines
pkg/nsx/services/securitypolicy/expand.go 93.75% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           v4.2.0     #831      +/-   ##
==========================================
+ Coverage   53.13%   53.74%   +0.61%     
==========================================
  Files          95       95              
  Lines       15049    15038      -11     
==========================================
+ Hits         7996     8082      +86     
+ Misses       6488     6380     -108     
- Partials      565      576      +11     
Flag Coverage Δ
unit-tests 53.74% <97.59%> (+0.61%) ⬆️
Files with missing lines Coverage Δ
pkg/nsx/services/securitypolicy/builder.go 82.30% <100.00%> (+0.47%) ⬆️
pkg/nsx/services/securitypolicy/expand.go 62.23% <93.75%> (+30.08%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@zhengxiexie zhengxiexie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timdengyun timdengyun merged commit 5ba13e7 into vmware-tanzu:v4.2.0 Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants