Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Subnet creating with stale VPC issue #825

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

wenqiq
Copy link
Contributor

@wenqiq wenqiq commented Oct 25, 2024

When creating and deleting the same Namespace and creating a Subnet in that Namespace, the creating Subnet may fail.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 69.04762% with 13 lines in your changes missing coverage. Please review.

Project coverage is 70.61%. Comparing base (ace5b09) to head (0904e44).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
pkg/nsx/services/vpc/vpc.go 61.76% 11 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
+ Coverage   64.78%   70.61%   +5.82%     
==========================================
  Files          96       95       -1     
  Lines       15154    15094      -60     
==========================================
+ Hits         9817    10658     +841     
+ Misses       4640     3710     -930     
- Partials      697      726      +29     
Flag Coverage Δ
unit-tests 70.61% <69.04%> (+5.82%) ⬆️
Files with missing lines Coverage Δ
.../controllers/networkinfo/networkinfo_controller.go 66.03% <100.00%> (+0.80%) ⬆️
pkg/nsx/services/vpc/store.go 67.36% <100.00%> (ø)
pkg/nsx/services/vpc/vpc.go 54.50% <61.76%> (-0.41%) ⬇️

... and 30 files with indirect coverage changes

pkg/nsx/services/vpc/vpc.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/vpc.go Outdated Show resolved Hide resolved
zhengxiexie
zhengxiexie previously approved these changes Oct 30, 2024
Copy link
Contributor

@zhengxiexie zhengxiexie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/controllers/networkinfo/networkinfo_controller.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/store.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/vpc.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/store.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/store.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/store.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/vpc.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/vpc.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/vpc.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/vpc.go Outdated Show resolved Hide resolved
Signed-off-by: Wenqi Qiu <[email protected]>
zhengxiexie
zhengxiexie previously approved these changes Nov 4, 2024
Copy link
Contributor

@zhengxiexie zhengxiexie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/nsx/services/vpc/vpc.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/vpc.go Show resolved Hide resolved
pkg/nsx/services/vpc/vpc.go Show resolved Hide resolved
pkg/nsx/services/vpc/vpc.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/vpc.go Outdated Show resolved Hide resolved
Signed-off-by: Wenqi Qiu <[email protected]>
Signed-off-by: Wenqi Qiu <[email protected]>
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, others LGTM

pkg/controllers/networkinfo/networkinfo_controller.go Outdated Show resolved Hide resolved
Signed-off-by: Wenqi Qiu <[email protected]>
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@timdengyun timdengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/nsx/services/vpc/vpc.go Show resolved Hide resolved
@wenqiq wenqiq merged commit bf1880a into vmware-tanzu:main Nov 5, 2024
2 checks passed
wenqiq added a commit to wenqiq/nsx-operator that referenced this pull request Nov 5, 2024
Fix the Subnet creating with stale VPC issue

Signed-off-by: Wenqi Qiu <[email protected]>
wenqiq added a commit to wenqiq/nsx-operator that referenced this pull request Nov 8, 2024
Fix the Subnet creating with stale VPC issue

Signed-off-by: Wenqi Qiu <[email protected]>
wenqiq added a commit that referenced this pull request Nov 8, 2024
Fix the Subnet creating with stale VPC issue

Signed-off-by: Wenqi Qiu <[email protected]>
@wenqiq wenqiq deleted the topic/wenqi/fix-subnet-vpc branch November 14, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants