-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Subnet creating with stale VPC issue #825
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
==========================================
+ Coverage 64.78% 70.61% +5.82%
==========================================
Files 96 95 -1
Lines 15154 15094 -60
==========================================
+ Hits 9817 10658 +841
+ Misses 4640 3710 -930
- Partials 697 726 +29
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6c9dbdb
to
3f71554
Compare
Signed-off-by: Wenqi Qiu <[email protected]>
3f71554
to
430a5c3
Compare
Signed-off-by: Wenqi Qiu <[email protected]>
430a5c3
to
71681fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Wenqi Qiu <[email protected]>
Signed-off-by: Wenqi Qiu <[email protected]>
Signed-off-by: Wenqi Qiu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, others LGTM
Signed-off-by: Wenqi Qiu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix the Subnet creating with stale VPC issue Signed-off-by: Wenqi Qiu <[email protected]>
Fix the Subnet creating with stale VPC issue Signed-off-by: Wenqi Qiu <[email protected]>
Fix the Subnet creating with stale VPC issue Signed-off-by: Wenqi Qiu <[email protected]>
When creating and deleting the same Namespace and creating a Subnet in that Namespace, the creating Subnet may fail.