Refactor subnet subnetset CRD status #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdengyun
force-pushed
the
remove_subnet_dhcp_options_add_gw_dhcp_status
branch
2 times, most recently
from
47a5263
to
a7bc26f
Compare
timdengyun
force-pushed
the
remove_subnet_dhcp_options_add_gw_dhcp_status
branch
3 times, most recently
from
eb41c14
to
b6ad3d3
Compare
timdengyun
changed the title
timdengyun
force-pushed
the
remove_subnet_dhcp_options_add_gw_dhcp_status
branch
from
b6ad3d3
to
bf9463f
Compare
jianjuns
reviewed
Jun 21, 2024
timdengyun
force-pushed
the
remove_subnet_dhcp_options_add_gw_dhcp_status
branch
from
bf9463f
to
da0d1cb
Compare
jianjuns
reviewed
Jun 24, 2024
timdengyun
force-pushed
the
remove_subnet_dhcp_options_add_gw_dhcp_status
branch
from
da0d1cb
to
a9fea04
Compare
1.Remove subnet CRD unused DHCP options since these fields are not used, so not expose to uesers. 2.Add gatewayAddresses and DHCPServerAddresses into the subnet CRD status field, also adding them in subnet field of subnetset CRD. 3.Rename status ipAddress to networkAddresses
timdengyun
force-pushed
the
remove_subnet_dhcp_options_add_gw_dhcp_status
branch
from
a9fea04
to
8b76e09
Compare
jianjuns
approved these changes
Jun 25, 2024
jwsui
approved these changes
Jun 26, 2024
timdengyun
added a commit
to timdengyun/nsx-operator-1
that referenced
this pull request
Aug 22, 2024
In the PR: vmware-tanzu#604 we have removed DNS-related config settings from subnet CRD. However, DNSClientConfig struct is not deleted. This PR is to remove this omitted struct definition.
timdengyun
added a commit
that referenced
this pull request
Aug 22, 2024
In the PR: #604 we have removed DNS-related config settings from subnet CRD. However, DNSClientConfig struct is not deleted. This PR is to remove this omitted struct definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Remove subnet CRD unused DHCP options since these fields are not
used, so not expose to uesers.
2.Add gatewayAddresses and DHCPServerAddresses into the subnet CRD status
field, also adding them in subnet field of subnetset CRD.
3.Rename status ipAddress to networkAddresses