Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LastTansitionTime in CR status #481

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jwsui
Copy link
Contributor

@jwsui jwsui commented Jan 15, 2024

Add LastTansitionTime in CR status which helps understand when the issue was encountered/resolved when viewing the CR.

tnqn#1 (comment)

@jwsui jwsui force-pushed the add-transition-time branch 3 times, most recently from 89d99cd to 8dff4c5 Compare January 15, 2024 06:15
@zhengxiexie
Copy link
Contributor

/e2e

1 similar comment
@zhengxiexie
Copy link
Contributor

/e2e

Add LastTansitionTime in CR status which helps understand when the
issue was encountered/resolved when viewing the CR.

tnqn#1 (comment)
@jwsui
Copy link
Contributor Author

jwsui commented Jan 22, 2024

/e2e

Copy link
Contributor

@timdengyun timdengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sp part LGTM

Copy link
Contributor

@zhengxiexie zhengxiexie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwsui jwsui merged commit 8b9d57e into vmware-tanzu:main Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants