Add retry to cleanup NSX resources #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantingl
reviewed
Nov 10, 2023
|
e2e |
|
/e2e |
1 similar comment
|
/e2e |
ihgann
reviewed
Nov 16, 2023
Add retry to Cleanup func, and summarize the errors returned to the upper. 1. failed to validate config 2. failed to get nsx client 3. failed to initialize cleanup service 4. failed to clean up specific resource We would retry 5 times if the 4th error occurs.
zhengxiexie
force-pushed
the
clean_retry
branch
from
133abe4 to
4e622fc
Compare
seanpang-vmware
approved these changes
Dec 8, 2023
zhengxiexie
added a commit
that referenced
this pull request
Dec 9, 2023
Add retry to cleanup NSX resources(#386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retry to Cleanup func, and summarize the errors returned to the upper.