Flux oci support part 4 #5032
Flux oci support part 4 #5032
Conversation
✅ Deploy Preview for kubeapps-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
| func NewLocalDockerConfigJsonSecret(ownerRepo types.NamespacedName) *apiv1.Secret { | ||
| return &apiv1.Secret{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| GenerateName: ownerRepo.Name + "-", |
There was a problem hiding this comment.
Perhaps we want to add some common labels like managed-by so that we can group/identify those resources more easily?
There was a problem hiding this comment.
That sounds good to me. A separate PR though, we make it consistent accross all plugins. This PR is about OCI support. Let me know and I will file an issue
| @@ -436,6 +439,14 @@ func (s *Server) validateUserManagedRepoSecret( | |||
| if secret.Data["keyFile"] == nil || secret.Data["certFile"] == nil { | |||
| return nil, status.Errorf(codes.Internal, "Specified secret [%s] missing fields 'keyFile' and/or 'certFile'", secretRef) | |||
| } | |||
| case corev1.PackageRepositoryAuth_PACKAGE_REPOSITORY_AUTH_TYPE_DOCKER_CONFIG_JSON: | |||
There was a problem hiding this comment.
Great, I'm updating my PR (#4954) to also support it. Thanks!
There was a problem hiding this comment.
Thank you for review
| @@ -514,11 +526,12 @@ func (s *Server) setOwnerReferencesForRepoSecret( | |||
| func (s *Server) updateKubeappsManagedRepoSecret( | |||
| ctx context.Context, | |||
| repoName types.NamespacedName, | |||
| typ string, | |||
There was a problem hiding this comment.
Just a slight preference towards type instead of typ, but up to you.
There was a problem hiding this comment.
yeah I wanted to do that. But VSCode is not letting me. I think 'type' may be a reserved keyword ?
| volumes: | ||
| - name: "config" | ||
| configMap: | ||
| name: "registry-configmap" |
There was a problem hiding this comment.
Not really important, but we tend to end with a line break. To do it, I use to set files.insertFinalNewline": true in VScode.
| @@ -94,7 +94,7 @@ require ( | |||
| k8s.io/kubernetes v1.22.10 | |||
| k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9 | |||
| oras.land/oras-go v1.2.0 | |||
| oras.land/oras-go/v2 v2.0.0-20220621073716-14422086e418 | |||
| oras.land/oras-go/v2 v2.0.0-alpha | |||
There was a problem hiding this comment.
They released v2.0.0-rc.1, perhaps you want to use it instead.
There was a problem hiding this comment.
yes, I am on it. Next PR
Incremental checkpoint. In this PR:
All tests (integration and unit) are passing