Easy way to provide custom values.schema.json files for Helm Charts #3535
Assignees
Labels
component/ui
Issue related to kubeapps UI
kind/feature
An issue that reports a feature (approved) to be implemented
Milestone
Comments
antgamdia
added
component/ui
|
Need to think about this as the Bitnami charts could potentially remove the current |
ppbaena
modified the milestones:
Adapt Kubeapps Forms to support JSONSchema,
Custom values
antgamdia
added a commit
that referenced
this issue
Oct 24, 2022
### Description of the change Once each of the PRs of the series related to [this milestone](https://github.com/vmware-tanzu/kubeapps/milestone/27) has been merged, this final one is adding/fixing the test cases: adding new ones for the functionality we've added and fixing others. Besides, some minor fixes have been added (which have been discovered with the unit tests :P) ### Benefits Tests will pass now. ### Possible drawbacks N/A ### Applicable issues - related #3535 ### Additional information > **Note** > This PR is part of a series of PRs aimed at closing [this milestone](https://github.com/vmware-tanzu/kubeapps/milestone/27). > PR 6 out of 6 Edit: existing e2e tests are also failing :S, will have a look at them next week. Signed-off-by: Antonio Gamez Diaz <[email protected]>
antgamdia
added a commit
that referenced
this issue
Oct 26, 2022
### Description of the change As per the discussion in #5530, this PR is adding a `featureFlags.schemaEditor` flag to enable the schema editor for those users who really want it. ### Benefits The schema editor will be available, but only if really needed. ### Possible drawbacks It is a work-in-progress feature until we also save the schema or use in the backend. ### Applicable issues - related #3535 ### Additional information I've fixed some typos here as well. Signed-off-by: Antonio Gamez Diaz <[email protected]>
antgamdia
added a commit
that referenced
this issue
Oct 26, 2022
### Description of the change The basic forms view has been recently revamped with plain JSON schema support. However, most of the charts (and maybe other packages) do not bring any schema file as part of their bundle. #3535 brings some ideas on how to solve it, but, this PR is just paving the way with a very simplistic approach: let users edit/add a schema from a text editor. Currently, there is no way to upload a file externally, but if this happens to be helpful, could be added in a follow-up PR. ### Benefits Users will be able to edit/add json schemas for improving the "basic form" experience (validations, defaults, etc...). ### Possible drawbacks Important: this "edited (or added)" schema is NOT being used on the backend side. Meaning you can't expect a proper validation or any further schema enforcement. Using the schema in the backend as well would imply some extra changes that could be performed in a follow-up PR if really needed. ### Applicable issues - fixes #3535 ### Additional information > **Note** > This PR is part of a series of PRs aimed at closing [this milestone](https://github.com/vmware-tanzu/kubeapps/milestone/27). I have split the changes to ease the review process, but as there are many interrelated changes, the tests will be performed in a separate PR (on top of the branch containing all the changes). > PR 1 out of 6  Signed-off-by: Antonio Gamez Diaz <[email protected]>
Repository owner
moved this from 🗂. Backlog
to ✅. Done
in Kubeapps
Oct 26, 2022
Repository owner
moved this from 🔎 In Review
to ✅ Done
in Kubeapps
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
This is not an issue, rather than a nice-to-have.
Currently, Kubeapps reads the
values.schema.jsonfile, from the helm chart. There are some public charts, without such file, or one that I (as a final user) want to modify according to my needs.Workaround for this is to customize the helm chart only to add my custom file, publish it to a chart repo like Harbor (and deploy it if needed), and add this custom Harbor to my kubeapps.
Would be very nice, if we could overwrite this file, either during
deployor by providing a repo, dedicated only for such files, with some predefined structure.The text was updated successfully, but these errors were encountered: