Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[velero] feat: add annotations for velero deployment and restic daemonset #217

Merged
merged 3 commits into from
Feb 24, 2021
Merged

[velero] feat: add annotations for velero deployment and restic daemonset #217

merged 3 commits into from
Feb 24, 2021

Conversation

cyril-corbon
Copy link
Contributor

@cyril-corbon cyril-corbon commented Feb 11, 2021 •
edited
Loading

Special notes for your reviewer:

This PR adds:

Ability to set annotation and label on Velero deployment
Ability to set annotation and label on Restic daemonset
Ability to set annotation and label on velero service

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

@cyril-corbon cyril-corbon force-pushed the feat-velero/add-dp-ds-annotations branch from 2e70a02 to 99c9db8 Compare February 11, 2021 12:45
@jenting
Copy link
Collaborator

jenting commented Feb 17, 2021

Related to #194

jenting
jenting requested changes Feb 17, 2021
View reviewed changes
Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion changes.

charts/velero/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/velero/templates/restic-daemonset.yaml Outdated Show resolved Hide resolved
@cyril-corbon cyril-corbon force-pushed the feat-velero/add-dp-ds-annotations branch from 8c21c0b to c8451fb Compare February 17, 2021 10:39
@cyril-corbon cyril-corbon requested a review from jenting February 17, 2021 11:20
jenting
jenting requested changes Feb 18, 2021
View reviewed changes
charts/velero/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/velero/templates/restic-daemonset.yaml Outdated Show resolved Hide resolved
@cyril-corbon cyril-corbon force-pushed the feat-velero/add-dp-ds-annotations branch from 4902d08 to 46cd60b Compare February 18, 2021 09:45
@cyril-corbon cyril-corbon requested a review from jenting February 18, 2021 09:50
@cyril-corbon
Copy link
Contributor Author

I Just applied the review and add labels / annotations to Deployments / Daemonset / Service

@cyril-corbon cyril-corbon force-pushed the feat-velero/add-dp-ds-annotations branch from 46cd60b to bb1c13d Compare February 24, 2021 08:19
@cyril-corbon
Copy link
Contributor Author

Is there any blocking point preventing you from merging this PR? What can I do for it to be merged ?

@jenting
Copy link
Collaborator

jenting commented Feb 24, 2021

Is there any blocking point preventing you from merging this PR? What can I do for it to be merged ?

Sorry for the delay review, I'll check it today. Thank u.

@jenting
Copy link
Collaborator

jenting commented Feb 24, 2021 •
edited
Loading

@cyril-corbon
Would you mind to bump the chart version? Thank u.

@cyril-corbon cyril-corbon force-pushed the feat-velero/add-dp-ds-annotations branch from bb1c13d to b77124a Compare February 24, 2021 10:45
@cyril-corbon cyril-corbon force-pushed the feat-velero/add-dp-ds-annotations branch from b77124a to 0cd8c70 Compare February 24, 2021 10:48
@cyril-corbon
Copy link
Contributor Author

@jenting I just done it 😄

jenting
jenting approved these changes Feb 24, 2021
View reviewed changes
Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank again.

@jenting
Copy link
Collaborator

jenting commented Feb 24, 2021

@cpanato @carlisia PTAL 🙇‍♂️

cpanato
cpanato approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jenting jenting merged commit b293d68 into vmware-tanzu:main Feb 24, 2021
@jenting jenting mentioned this pull request Feb 24, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

@cpanato cpanato cpanato approved these changes

@carlisia carlisia Awaiting requested review from carlisia

Assignees

@cyril-corbon cyril-corbon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyril-corbon @jenting @cpanato