Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velero] feat(schedule): add annotation templating #199

Merged

Conversation

eyenx
Copy link
Contributor

@eyenx eyenx commented Dec 28, 2020

Special notes for your reviewer:

As with vmware-tanzu/velero#3067, annotations of the schedule get propagated into the backups. This allows us to set annotations on schedules over this chart.

Attention: vmware-tanzu/velero#3067 isn't yet released.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

@eyenx eyenx force-pushed the feature/add-annotations-to-schedule branch from 78e6049 to 50e3f43 Compare December 28, 2020 09:42
Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @eyenx, left one comment

Signed-off-by: Toni Tauro <[email protected]>

Update charts/velero/templates/schedule.yaml

Co-authored-by: JenTing Hsiao <[email protected]>
@eyenx eyenx force-pushed the feature/add-annotations-to-schedule branch from 0e61886 to 977c735 Compare December 28, 2020 14:27
@eyenx eyenx requested a review from jenting December 28, 2020 14:28
@jenting
Copy link
Collaborator

jenting commented Jan 11, 2021

@carlisia @cpanato could you please take a look at this?

The CI helm2-lint-test failing is because the stable chart repo moved to a new location.
So, I think we could pass helm2 CI failure since it's not Required.

I have filed a PR for the helm CI test action.

Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jenting jenting merged commit 20191d4 into vmware-tanzu:main Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants