This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Update ytt dependency to be portable on Windows. #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an issue described in carvel-dev/ytt#524, we need to rely on a fork of `ytt` which changes an expected constant/key. Once this is closed, we should go back to pointing at an official tag. Without this in place, ytt parsing will fail when our binary is run on Windows. Signed-off-by: joshrosso <[email protected]>
stmcginnis
approved these changes
Oct 27, 2021
joshrosso
pushed a commit
that referenced
this pull request
Jan 18, 2022
Due to an issue described in carvel-dev/ytt#524, we need to rely on a fork of `ytt` which changes an expected constant/key. Once this is closed, we should go back to pointing at an official tag. Without this in place, ytt parsing will fail when our binary is run on Windows. Signed-off-by: joshrosso <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an issue described in
carvel-dev/ytt#524, we need to rely
on a fork of
yttwhich changes an expected constant/key. Once this isclosed, we should go back to pointing at an official tag. Without this
in place, ytt parsing will fail when our binary is run on Windows.
Signed-off-by: joshrosso [email protected]