Allow when= to access value, parent, and root nodes #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... because line numbers can sometimes be not present (e.g. data values
being calculated) or shifted.
... to improve readability. Usability testing (#707) made clear that violation messages on a single line are quite difficult to visually parse, making such error messages less readable. To support the reformatting, context is gathered at the time a violation is detected. The message is formatted once all violations have been collected. Also includes minor improvements to "named" rule messages to improve readability.
cppforlife
reviewed
Sep 12, 2022
cppforlife
reviewed
Sep 12, 2022
pkg/yamltemplate/filetests/ytt-library/assert/max_len/value-fails-assertion.tpltest
Show resolved
Hide resolved
...rather than mapping to a name argument; this is unlike any other interaction in `ytt` authoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #733