feat: add common build environment #14
Conversation
ereslibre
force-pushed
the
build-environment
branch
23 times, most recently
from
cdb90a0 to
6cec5f0
Compare
ereslibre
force-pushed
the
build-environment
branch
2 times, most recently
from
f98b874 to
8ac25fb
Compare
ereslibre
force-pushed
the
build-environment
branch
2 times, most recently
from
1387121 to
d4a80a5
Compare
There was a problem hiding this comment.
The PR looks amazing @ereslibre! This simplifies the build a lot and it ensure the builds are consistent across different environments 👏 .
Added a few minor comments before approving it. Thanks!
| 2. You can find `php-cgi` in `$WASMLABS_BUILD_OUTPUT/bin/php-cgi` | ||
|
|
||
| # Running a script with php-cgi | ||
| ## Running a script with php-cgi |
There was a problem hiding this comment.
Even though this PR simplifies build a lot, I would still keep some information in the README file about the commands to build PHP. Even it's a simple make php-X. In that way, I don't need to check all the files in the folder, look for a "build" system, notice the Makefile file and read it before knowing the command.
There was a problem hiding this comment.
Yeah, you are right. I was a bit dubious about adding it because it's easy to forget updating the README when we update the versions.
However I think we can add automation to fix that problem. I have some ideas we can discuss :)
There was a problem hiding this comment.
Is that fine now?
|
|
||
| .PHONY: wasi-builder-16 | ||
| wasi-builder-16: | ||
| docker build --build-arg WASI_SDK_VERSION=16 -f ${BUILDER_ROOT_DIR}/Dockerfile.wasi-builder -t ghcr.io/vmware-labs/wasi-builder:16 ${BUILDER_ROOT_DIR} |
There was a problem hiding this comment.
Shouldn't this be tagged in projects.registry.vmware.com/wasmlabs/containers instead of ghcr.io ?
There was a problem hiding this comment.
I realized with this work that we can publish on ghcr.io already (https://github.com/orgs/vmware-labs/packages/container/package/wasi-builder) and (https://github.com/orgs/vmware-labs/packages/container/package/php-builder).
I think we might want to discuss it. If we are going to work with GitHub workflows and automate stuff on GitHub I think it might be more convenient to deploy assets on the GitHub registry, given it makes authentication & authorization easier and more integrated.
ereslibre
force-pushed
the
build-environment
branch
3 times, most recently
from
66cd689 to
6b56531
Compare
Add a build environment based on container images that can reproduce the build in multiple environments. Signed-off-by: Rafael Fernández López <[email protected]>
ereslibre
force-pushed
the
build-environment
branch
from
6b56531 to
92a8c55
Compare
Fixes: #6
Fixes: #10
Add a build environment based on container images that can reproduce the build in multiple environments. To be completed: