-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WLR simplified build scripts, actions and structure #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @assambar. I think this approach is fine, and it will help with maintenance moving forward.
b8e220c
to
dcc32d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you @assambar! I love the direction, and I think is worth getting merged and continuing evolving as we see need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge and amazing refactor! I believe the build experience is now more consistent and simpler. Congrats on this work! 👏
As we bumped WASI SDK and the major runtimes to the latest versions there was a lot of copy-pasting and dealing with mind boggling things in the build scripts.
This PR aims to reduce this for future changes.
v${MAJOR}.${MINOR}.${BUILD}
format now, as the actual source tag is described inwlr-env-repo.sh
file. (for examplephp/php-8.2.0
would be moved tophp/v8.2.0
). This immensely simplifies GH actions.build-output
root now (instead of complex, highly customizable GH Actions doing this for different flavors)wlr-build.sh
scripts now have to consider the WLR_BUILD_FLAVOR variable if they want to handle different flavors.Note: There is more that could be generalized/simplified but I had to draw the line. The change is already way too big and time consuming for the value it brings.
Here is what the release builds for the major runtimes look now
And here are samples for the published releases: