Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WLR simplified build scripts, actions and structure #114

Merged
merged 12 commits into from
Jul 14, 2023
Merged

Conversation

assambar
Copy link
Contributor

@assambar assambar commented Jun 30, 2023

As we bumped WASI SDK and the major runtimes to the latest versions there was a lot of copy-pasting and dealing with mind boggling things in the build scripts.

This PR aims to reduce this for future changes.

  • All target folders follow the v${MAJOR}.${MINOR}.${BUILD} format now, as the actual source tag is described in wlr-env-repo.sh file. (for example php/php-8.2.0 would be moved to php/v8.2.0). This immensely simplifies GH actions.
  • All build scripts prepare the necessary assets into the build-output root now (instead of complex, highly customizable GH Actions doing this for different flavors)
  • GH actions are simplified to dealing with *.{gz,wasm,txt} files instead of complex names. Reusable stuff is extracted in callable workflows
  • All flavor targets are handled by GNU Make (instead of folders with symlinks or copy pasted scripts). Note that all wlr-build.sh scripts now have to consider the WLR_BUILD_FLAVOR variable if they want to handle different flavors.
  • Developer notes were moved from README.md to docs/developers.md and updated

Note: There is more that could be generalized/simplified but I had to draw the line. The change is already way too big and time consuming for the value it brings.


Here is what the release builds for the major runtimes look now

And here are samples for the published releases:

Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @assambar. I think this approach is fine, and it will help with maintenance moving forward.

@assambar assambar force-pushed the slim-flavors branch 2 times, most recently from b8e220c to dcc32d6 Compare July 11, 2023 13:58
@assambar assambar changed the title WIP: slim flavors and php 8.2.6 WLR simplified build scripts, actions and structure Jul 13, 2023
@assambar assambar marked this pull request as ready for review July 13, 2023 14:42
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @assambar! I love the direction, and I think is worth getting merged and continuing evolving as we see need.

@assambar assambar merged commit 11be424 into main Jul 14, 2023
@assambar assambar deleted the slim-flavors branch July 14, 2023 10:04
Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge and amazing refactor! I believe the build experience is now more consistent and simpler. Congrats on this work! 👏

docs/developers.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants