Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check missing runtimes before loading workers #90

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

Angelmmiguel
Copy link
Contributor

When a user downloads an existing project, the required runtimes won't be installed. As part of the process, they need to download it using wws runtimes install as other similar tools like NodeJS. We want to provide a hint about this behavior so wws doesn't fail and it shows useful information.

From now on, wws will look for missing runtimes when running the run command (default one). If there're missing runtimes, it will show a message and will ask users to install it using wws runtimes install. In the future, we will evaluate if installing missing runtimes should be part of the regular process.

In addition to that, now wws will ignore the extensions of not installed runtimes.

./wws .
⚠️  Required language runtimes are not installed. Some files may not be considered workers
⚠️  You can install the missing runtimes with: wws runtimes install
⚙️  Loading routes from: .
🗺  Detected routes:
🚀 Start serving requests at http://127.0.0.1:8080

It closes #69

@Angelmmiguel Angelmmiguel added the 🚀 enhancement New feature or request label Feb 13, 2023
@Angelmmiguel Angelmmiguel requested a review from a team February 13, 2023 12:38
@Angelmmiguel Angelmmiguel self-assigned this Feb 13, 2023
@Angelmmiguel Angelmmiguel added this to the v1.0.0 milestone Feb 14, 2023
Copy link
Contributor

@assambar assambar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good improvement!

src/runtimes/manager.rs Outdated Show resolved Hide resolved
@Angelmmiguel Angelmmiguel merged commit 1f8ab4c into main Feb 14, 2023
@Angelmmiguel Angelmmiguel deleted the 69-check-missing-runtimes branch May 8, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check required lang runtimes when running wws (from .wws.toml)
3 participants