Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid service JS files inside public folder as worker #38

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

Angelmmiguel
Copy link
Contributor

Ensure that assets in the public folder are always served as static. Before this PR, .js files inside the public folder will be processed as workers.

It closes #36

@Angelmmiguel Angelmmiguel added the 🐛 bug Something isn't working label Nov 21, 2022
@Angelmmiguel Angelmmiguel self-assigned this Nov 21, 2022
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A question regarding public named directories.

src/router.rs Show resolved Hide resolved
@Angelmmiguel Angelmmiguel merged commit 426aa6a into main Nov 22, 2022
@Angelmmiguel Angelmmiguel deleted the 36-fix-public-assets branch May 8, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working cla-not-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip any file in the public folder when loading routes
3 participants