Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing console.trace method #249

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: add missing console.trace method #249

merged 1 commit into from
Oct 20, 2023

Conversation

Angelmmiguel
Copy link
Contributor

Add the missing console.trace method to the JavaScript SDK.

It closes #248

@Angelmmiguel Angelmmiguel added 🐛 bug Something isn't working 🔨 sdks Issues related to language SDKs labels Oct 20, 2023
@Angelmmiguel Angelmmiguel added this to the 1.7.0 milestone Oct 20, 2023
@Angelmmiguel Angelmmiguel requested a review from a team October 20, 2023 07:19
@Angelmmiguel Angelmmiguel self-assigned this Oct 20, 2023
ereslibre
ereslibre approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 👏

@Angelmmiguel Angelmmiguel force-pushed the 248-missing-console-trace branch from 0a80437 to bdb5971 Compare October 20, 2023 08:00
@Angelmmiguel Angelmmiguel merged commit 691f70a into main Oct 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereslibre ereslibre ereslibre approved these changes

Assignees

@Angelmmiguel Angelmmiguel

Labels
🐛 bug Something isn't working cla-not-required 🔨 sdks Issues related to language SDKs
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

console.trace is missing in the JS kit
3 participants
@Angelmmiguel @ereslibre @vmwclabot