Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call to the toString method when Response receives a String object #239

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: call to the toString method when Response receives a String object #239

merged 1 commit into from
Oct 18, 2023

Conversation

Angelmmiguel
Copy link
Contributor

Call the toString to convert the current String object into a string primitive. After applying this change, wws returns the proper response when running the #238 example:

$ curl localhost:8080/test
<!DOCTYPE html>
      <h1>Hello! test!</h1>

It fixes #238

@Angelmmiguel Angelmmiguel added 🐛 bug Something isn't working 🔨 sdks Issues related to language SDKs labels Oct 18, 2023
@Angelmmiguel Angelmmiguel added this to the 1.7.0 milestone Oct 18, 2023
@Angelmmiguel Angelmmiguel requested a review from a team October 18, 2023 07:33
@Angelmmiguel Angelmmiguel self-assigned this Oct 18, 2023
@Angelmmiguel Angelmmiguel merged commit f40e7da into main Oct 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereslibre ereslibre ereslibre approved these changes

Assignees

@Angelmmiguel Angelmmiguel

Labels
🐛 bug Something isn't working cla-not-required 🔨 sdks Issues related to language SDKs
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

The JavaScript kit returns a wrong result when using Hono's html helper
3 participants
@Angelmmiguel @ereslibre @vmwclabot