feat: add Zig mount example #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereslibre
commented
Sep 13, 2023
| @@ -90,7 +97,7 @@ pub const Output = struct { | |||
| } | |||
|
|
|||
| // prepare writer for json | |||
| var out_buf: [1024]u8 = undefined; | |||
| var out_buf: [4096]u8 = undefined; | |||
There was a problem hiding this comment.
When this merges I'm going to open an issue to need an allocator here instead of fixed sizes on the stack.
| @@ -129,7 +134,7 @@ fn base64Encode(data: []const u8) []const u8 { | |||
| // This initializing Base64Encoder throws weird error if not wrapped in function (maybe Zig bug?) | |||
| var enc = std.base64.Base64Encoder.init(std.base64.standard_alphabet_chars, '='); | |||
| var data_len = enc.calcSize(data.len); | |||
| var buf: [128]u8 = undefined; | |||
| var buf: [16384]u8 = undefined; | |||
There was a problem hiding this comment.
When this merges I'm going to open an issue to need an allocator here instead of fixed sizes on the stack.
ereslibre
force-pushed
the
zig-mount
branch
from
d19035a to
c4507c0
Compare
Angelmmiguel
approved these changes
Sep 13, 2023
| @@ -90,7 +97,7 @@ pub const Output = struct { | |||
| } | |||
|
|
|||
| // prepare writer for json | |||
| var out_buf: [1024]u8 = undefined; | |||
| var out_buf: [4096]u8 = undefined; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.