Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document catch all routes #214

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Document catch all routes #214

merged 4 commits into from
Sep 13, 2023

Conversation

ereslibre
Copy link
Contributor

Fixes: #213

@ereslibre ereslibre requested a review from a team September 12, 2023 09:58
@ereslibre ereslibre added this to the v1.6.0 milestone Sep 12, 2023
Angelmmiguel
Angelmmiguel approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general! Added some minor comments, but approving it in advance so you can merge after fixing it :).

Thank you for fixing all the tables btw!

docs/docs/features/dynamic-routes.md Show resolved Hide resolved
docs/docs/features/dynamic-routes.md Outdated Show resolved Hide resolved
examples/js-catchall/other/[...slug]/index.js Outdated Show resolved Hide resolved
@ereslibre
Copy link
Contributor Author

Thank you for fixing all the tables btw!

Haha, my editor does automatically when I edit a table :D

@ereslibre ereslibre force-pushed the document-catch-all-routes branch from eec855d to 1f7fe70 Compare September 13, 2023 08:52
@ereslibre ereslibre force-pushed the document-catch-all-routes branch from 1f7fe70 to 3b83df6 Compare September 13, 2023 08:57
@ereslibre ereslibre merged commit 65c71c7 into vmware-labs:main Sep 13, 2023
@ereslibre ereslibre deleted the document-catch-all-routes branch September 13, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angelmmiguel Angelmmiguel Angelmmiguel approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Document catch all routes
3 participants
@ereslibre @Angelmmiguel @vmwclabot