Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support IPv6 hostname #19

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

taisukef
Copy link
Contributor

on previous version

wws --host "[::]"
Error: Custom { kind: Uncategorized, error: "failed to lookup address information: nodename nor servname provided, or not known" }

@vmwclabot
Copy link

@taisukef, VMware has approved your signed contributor license agreement.

@ereslibre
Copy link
Contributor

Thank you @taisukef. I cannot reproduce this issue neither at main or with the 0.5.0 released version.

@Angelmmiguel Angelmmiguel self-requested a review November 7, 2022 14:34
@Angelmmiguel
Copy link
Contributor

Hello @taisukef,

I checked the issue with @ereslibre and we were able to reproduce the issue. The current version works fine on Linux, but we get the same error you are pointing out in macOS. I also found a similar a related issue in actix-web, the framework we're using to manage the HTTP requests (actix/actix-web#1320).

The proposed solution in that issue looks similar to your PR. For us, it seems the bind method should be the one dealing with this case. Let us revisit the bind definition at actix-web and we will sync on the PR with you for the final solution.

Meanwhile, you can use the "extended" IPv6 for localhost:

wws --host "0:0:0:0:0:0:0:1"

Thank you for your PR!

Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @Angelmmiguel said we could reproduce this both on Mac OS X and GNU/Linux. Only that it was taking a while to bind so I could not see the error after certain time had passed.

Thanks for the contribution @taisukef! LGTM

Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved too! Thanks for your contribution :)

@Angelmmiguel Angelmmiguel merged commit 85daf46 into vmware-labs:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants