chore: place wws under /opt/wws and keep /app in prebuilt images too #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereslibre
force-pushed
the
same-container-image-structure
branch
from
5be4ffa to
6a4d67c
Compare
There was a problem hiding this comment.
Thanks for the update @ereslibre! Totally agree on consolidating the wws binary location in the different images.
I added a comment regarding the ENTRYPOINT after this change.
ereslibre
force-pushed
the
same-container-image-structure
branch
from
6a4d67c to
99c60e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place wws under /opt in the container images that use prebuilt binaries, in the same place as the container images that build the project to reduce the drift and surprises depending if a user build the container on their own machine, or if they pull
ghcr.io/vmware-labs/wws:previewfor example.