feat: add new Go bindings to perform HTTP requests #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ereslibre
reviewed
Jul 10, 2023
There was a problem hiding this comment.
LGTM, great work @Angelmmiguel. Minor comments and questions.
wit/go-ephemeral/http-types.wit
Outdated
There was a problem hiding this comment.
This file exists due to the issues you mentioned with WIT format and incompatibilities at the WIT format between those versions, right? I guess, the idea is to have a single WIT directory with the definitions that all kits consume at some point, right?
There was a problem hiding this comment.
Exactly. WIT has evolved a lot and there're some breaking changes while the spec stabilizes. The end goal is to have a single WIT definition once we can recreate all kits based on it.
Currently, this is the situation:
- core: oldest WIT version
- go-ephemeral: WIT version before packages
Co-authored-by: Rafael Fernández López <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the new HTTP bindings for the Go kit and expose a new
SendHttpRequestmethod. It includes new WIT files that are required due to a mismatch between thewit-bindgenversion used by the host (v0.2) and the Go kit (v0.6). I also had to adapt the generated code to work between these versions. You have all the information in thekits/go/worker/README.mdfile.Changes
wit/corebut are compatible withwit-bindgenv0.6.kits/go/worker/README.mdfile.SendHttpRequestmethod in the Go kit.http.Requestandhttp.Responsestructs instead of the internal ones.It refs #165