Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new fetch bindings to the rust kit #171

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

Angelmmiguel
Copy link
Contributor

@Angelmmiguel Angelmmiguel commented Jul 5, 2023

This PR is built on top of #168. We will need to merge and rebase this branch before

This PR exposes new bindings to make HTTP requests from a Rust kit. To define the Request and Response we use the default structs from the http crate. Regarding errors, we will expose the HttpRequestError enum as it provides a more specific set of errors.

I also included a new example for rust.

It refs #165

Pending

  • Enables a request with a Vec<u8> body
  • Update docs to point to a specific Wasm Workers Server version. If someones tries to build a Rust worker with the new bindings using the previous wws version, it won't work.

@Angelmmiguel Angelmmiguel added the 🚀 enhancement New feature or request label Jul 5, 2023
@Angelmmiguel Angelmmiguel added this to the v1.4.0 milestone Jul 5, 2023
@Angelmmiguel Angelmmiguel self-assigned this Jul 5, 2023
@Angelmmiguel Angelmmiguel force-pushed the 165-add-http-requests-to-rust branch from de0b3fa to 3473412 Compare July 5, 2023 12:04
@Angelmmiguel Angelmmiguel marked this pull request as ready for review July 5, 2023 12:22
@Angelmmiguel Angelmmiguel requested a review from a team July 5, 2023 12:34
@Angelmmiguel Angelmmiguel force-pushed the 165-add-http-requests-to-rust branch from 6b6efab to 0bc6094 Compare July 6, 2023 07:05
@Angelmmiguel Angelmmiguel changed the base branch from 165-add-http-bindings to main July 6, 2023 07:05
@Angelmmiguel Angelmmiguel merged commit e7f389e into main Jul 6, 2023
@Angelmmiguel Angelmmiguel deleted the 165-add-http-requests-to-rust branch July 6, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants