-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: install openssl@3 when building wws in actions #164
Conversation
… macOS on GitHub actions
To fix this, I tried several approaches, from installing architecture-specific packages with brew to set the OpenSSL location. After checking for multiple issues around, I found that OpenSSL is specially difficult to integrate in projects that targets multiple platforms. Even the cross team removed OpenSSL because it was difficult to maintain. That was another approach I wanted to try 🥲. Finally, I decided to make the This PR / issue is another one on the "OpenSSL" related issues archive. I believe we should move to |
I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Angelmmiguel 👏
When releasing
wws
v1.3, theartifacts
action was failing for macOS. The issue was related to theopenssl
crate upgrade on #132.This is the error message from the job:
Based on the
openssl
crate documentation, you need to install OpenSSL to build it. I assume the action runner was installing and old version that it's no longer valid for the crate and we need to explicitly install the latest one.