-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow git remote repositories (https) as project locations #152
Conversation
Signed-off-by: Angel M De Miguel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Very nice feature! LGTM, some comments from my side :)
Co-authored-by: Rafael Fernández López <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Angelmmiguel!
if let Some(options) = options { | ||
if let Some(git) = options.git { | ||
if let Some(git_ref) = git.git_ref { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been looking for a better way to express this, but it requires let_chains
and is unstable. :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, a new approach for "let chains" would be really great 😄. I will keep an eye on this. Thanks for the pointer.
Add support for git repositories as valid project locations. Now you can run a project directly from a remote repository. There are different options to configure the git repository. These are all the new options:
Here you have an example:
It closes #147
Install missing language runtimes
Some workers require specific runtimes. For example, you need to download a Python or Ruby runtime to develop workers based on these languages.
wws
stores this information in the.wws.toml
, so you can install them withwws runtimes install
.When pulling a repository is convenient to install the missing runtimes directly. However, we may not want to make this the default behavior as you need to download "arbitrary" binaries for Internet. For this reason, I added an option to install runtimes automatically, so you can enable it for projects you trust: