Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename the runtimes-manager crate to project #150

Merged
merged 2 commits into from
Jun 1, 2023
Merged

refactor: rename the runtimes-manager crate to project #150

merged 2 commits into from
Jun 1, 2023

Conversation

Angelmmiguel
Copy link
Contributor

I want to rename this crate to highlight its new scope:

  • Download and initialize projects
  • Download runtimes

You have all the reasoning behind this change on: #147 (comment).

It references #147

@Angelmmiguel Angelmmiguel requested a review from a team June 1, 2023 07:50
@Angelmmiguel Angelmmiguel self-assigned this Jun 1, 2023
ereslibre
ereslibre approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the new name LGTM. I think is descriptive of what it does.

crates/project/README.md Outdated Show resolved Hide resolved
@Angelmmiguel @ereslibre
fix: update crates/project/README.md
853c201 
Co-authored-by: Rafael Fernández López <[email protected]>
@Angelmmiguel Angelmmiguel merged commit e2faca4 into main Jun 1, 2023
@Angelmmiguel Angelmmiguel deleted the 147-rename-runtimes-manager branch June 30, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereslibre ereslibre ereslibre approved these changes

Assignees

@Angelmmiguel Angelmmiguel

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Angelmmiguel @ereslibre @vmwclabot