Build images #15
Merged
Build images #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assambar
force-pushed
the
build-images
branch
from
bddc3d3 to
ef679fb
Compare
Angelmmiguel
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
The PR looks great!! I just added some minor comments @assambar. Only one applies to this PR, the other can be done in a separate one. I already approved it, so we can squash and merge right after.
Thanks!
assambar
force-pushed
the
build-images
branch
from
ef679fb to
cc2b75b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #11