Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing certs to the wws container #148

Merged
merged 1 commit into from
May 31, 2023

Conversation

Angelmmiguel
Copy link
Contributor

Add local certificates so wws can install runtimes in the images we build from scratch. This was missing on the preview and tagged container we publish.

I already tested it on the containderd-wasm-shims project.

It fixes #120

@Angelmmiguel Angelmmiguel added the 🐛 bug Something isn't working label May 31, 2023
@Angelmmiguel Angelmmiguel added this to the v1.2.0 milestone May 31, 2023
@Angelmmiguel Angelmmiguel requested a review from a team May 31, 2023 09:10
@Angelmmiguel Angelmmiguel self-assigned this May 31, 2023
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Angelmmiguel Angelmmiguel merged commit 065ec01 into main May 31, 2023
@Angelmmiguel Angelmmiguel deleted the 120-add-missing-certificates-to-containers branch June 30, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working cla-not-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The wws container image doesn't include valid certificates
3 participants