Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cargo deny initial configuration and run it in the CI #140

Merged
merged 2 commits into from
May 26, 2023

Conversation

Angelmmiguel
Copy link
Contributor

Introduce the cargo-deny CLI to the project, add the initial configuration and run it in the CI. The configuration is based on the current status of the project. I tried to ban duplicated crates, but I got multiple failures that we need to check and skip manually. Once we update Wasmtime (#132), we can revisit this check and manually skip the ones we consider fine.

As part of this PR, I updated a dependency that included an advisory :)

It closes #139

@Angelmmiguel Angelmmiguel added the 🚀 enhancement New feature or request label May 26, 2023
@Angelmmiguel Angelmmiguel added this to the v1.1.2 milestone May 26, 2023
@Angelmmiguel Angelmmiguel requested a review from a team May 26, 2023 06:30
@Angelmmiguel Angelmmiguel self-assigned this May 26, 2023
deny.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@gzurl gzurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just single comment about denying licenceses

Copy link
Contributor

@assambar assambar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Copy link
Contributor

@assambar assambar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@Angelmmiguel Angelmmiguel merged commit 790671d into main May 26, 2023
@Angelmmiguel Angelmmiguel deleted the 139-add-cargo-deny branch June 30, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce cargo-deny in the project
4 participants