Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #14

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Fix typos #14

merged 1 commit into from
Oct 25, 2022

Conversation

ssssota
Copy link
Contributor

@ssssota ssssota commented Oct 19, 2022

Very interesting project!

Fixed typo in the documents.

@vmwclabot
Copy link

@ssssota, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link

@ssssota, we have received your signed contributor license agreement. It will be reviewed by VMware shortly. Another comment will be added to the pull request to notify you when the merge can proceed.

ereslibre
ereslibre suggested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ssssota! A couple of suggestions. Once that the license agreement is accepted we can merge your fixes!

docs/docs/intro.md Outdated Show resolved Hide resolved
docs/docs/intro.md Outdated Show resolved Hide resolved
@vmwclabot
Copy link

@ssssota, VMware has approved your signed contributor license agreement.

@ssssota ssssota requested a review from ereslibre October 25, 2022 03:00
@gzurl
Copy link
Contributor

gzurl commented Oct 25, 2022

Thanks @ssssota for your patch!
@ereslibre this LGTM now. But you are the change request owner :-)

@gzurl gzurl self-requested a review October 25, 2022 12:30
gzurl
gzurl approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@gzurl gzurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ereslibre
Copy link
Contributor

Thank you @ssssota!

@ereslibre ereslibre merged commit 51e7dcf into vmware-labs:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzurl gzurl gzurl approved these changes

@ereslibre ereslibre ereslibre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ssssota @vmwclabot @gzurl @ereslibre