Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add e2e tests to check different examples are working properly #134

Merged
merged 18 commits into from
May 25, 2023

Conversation

Angelmmiguel
Copy link
Contributor

Introduce a new set of e2e tests to confirm wws binary is working properly. Currently, we're testing the following cases:

  • examples/js-basic
  • examples/js-json
  • examples/js-params
  • examples/rust-basic
  • examples/rust-kv

I also introduce a change in the CI to build the binary in different platforms during the PR too. The end goal is to ensure PRs don't break the basic features.

@Angelmmiguel
Copy link
Contributor Author

The tests will pass after #136 is merged and I rebase the branch.

Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

.github/workflows/build.yml Outdated Show resolved Hide resolved
tests/e2e.rs Outdated Show resolved Hide resolved
@Angelmmiguel Angelmmiguel force-pushed the 132-bump-and-integration branch from 75fb206 to 11f3b91 Compare May 25, 2023 06:24
@gzurl gzurl self-requested a review May 25, 2023 08:25
Copy link
Contributor

@gzurl gzurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Angelmmiguel Angelmmiguel merged commit feedff9 into main May 25, 2023
This was referenced May 29, 2023
@Angelmmiguel Angelmmiguel deleted the 132-bump-and-integration branch June 30, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants