-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Go #129
Add support for Go #129
Conversation
@mnafees, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
@mnafees, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
@mnafees, VMware has approved your signed contributor license agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mnafees ,
Thank you for this amazing contribution! I added two minor comments. The code looks great and all the examples work perfectly.
Apart from the examples, we should include a new documentation page for Go. It's not a blocker for merging this, so we can work on it in a separate PR. If it's fine for you, I would add a note in that documentation page mentioning you as the original author of the Go kit.
Thank you! 🎉
I am going to add code comments as well as the docs for the new Go support kit and update the PR accordingly :) |
Hey @mnafees! This is just a check on the status of this PR :). I believe the current Go kit is in a great shape to included in the project. If you are more busy lately, I can do a final review, merge it and create an issue to work on the documentation in a separate PR. If you prefer to complete the documentation on this PR, feel free to add it too. No rush for it. I just wanted to to do a check since the latest comment was from a few days ago. Thanks! |
Hi @Angelmmiguel, apologies for being AWOL for a while. I got busy with other work. I am updating the PR with the docs. I also went ahead and chose to use the |
Hello @mnafees! No worries, you don't need to apologize 😄. I regularly check open PRs in case I can help on anything. Thank you very much for your contribution! 👏 |
@Angelmmiguel I have updated the PR with all of my changes to the documentation :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great @mnafees! Thank you very much for this contribution 😄. I'm really happy to see that wws
supports Go now 👏.
Btw, I'll write an article about a new release and I'll be sure to include the recent contributions like this one there 😄.
Btw, no worries about the issue on the CI. It's a flaky test I need to fix in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing contribution @mnafees! LGTM 👏, 🚢 it!
Awesome contribution @mnafees! 🚀 |
This PR adds support for Go support.
Currently, only compiled WASM modules using TinyGo is supported. This comes as a result of TinyGo supporting WASI whereas the original Go compiler emits WASM that needs to be accompanied with a wrapper JS file.
To compile
Resolves #95