Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configuring stderr when running the server #127

Merged
merged 3 commits into from
May 8, 2023

Conversation

Angelmmiguel
Copy link
Contributor

Allow to configure the stderr in the WASI context that runs the workers. This will allow a Wasm module to print the error logs in a specific file when configured.

This value is optional. If it's not configured, it will inherit the value from the environment.

It closes #125

containerd-wasm-shims

This feature was implemented to allow modules print messages in a custom stderr for deislabs/containerd-wasm-shims/pull/88. Here you can see the logs printed in the proper location:

Screenshot 2023-05-08 at 09 05 06

@Angelmmiguel Angelmmiguel added the 🚀 enhancement New feature or request label May 8, 2023
@Angelmmiguel Angelmmiguel requested review from assambar and a team May 8, 2023 07:05
@Angelmmiguel Angelmmiguel self-assigned this May 8, 2023
@Angelmmiguel Angelmmiguel merged commit 5207684 into main May 8, 2023
@Angelmmiguel Angelmmiguel deleted the 125-configure-stderr branch June 30, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make stderr configurable when running a worker
3 participants