-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split wws code in multiple crates #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereslibre
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Angelmmiguel! It's awesome to see how this code evolves.
Co-authored-by: Rafael Fernández López <[email protected]>
ereslibre
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 🚢 it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to split the current project into separate crates. Currently, all the code is split in modules inside the
./src
folder. This is causing some issues:wws
as a library, it needs to compile the entire project. This includesclap
and other libraries that are only related to thewws
CLIworkspace
tooling to manage and share dependencies easilyNow it's a great moment to perfrom these changes as we just released a new version and we're planning to start using
wws
as a library.For now, I identified these crates:
config
: manage thewws
global configuration (.wws.toml
file)data-kv
: manage the KV in-memory store we ship with wwsrouter
: define the routes by loading files from the local filesystem. It also initializes the workersruntimes
: initalize and configurewasmtime
to run workers' source code.runtimes-manager
: interacts with the remote repository to install and uninstall language runtimes (ruby, python, etc)server
: run the final HTTP server users can querystore
: manage the temporary store for the runtime and worker files / foldersworker
: initialize all the required resources to run a worker from the given file. It also calls theruntime
to return a responseIt closes #102