chore: fix all clippy suggestions on the new version (#245)

* chore: fix all clippy suggestions on the new version

* feat: improve CI times and caching by avoiding incremental builds and debug info

.github/workflows/build.yml

@@ -7,6 +7,10 @@ on:
     branches: [ "main", "v[0-9]+.[0-9]+" ]
 
 env:
+  # Disabling debug info and incremental builds to speed up builds a bunch.
+  # See https://matklad.github.io/2021/09/04/fast-rust-builds.html#CI-Workflow
+  CARGO_INCREMENTAL: 0
+  CARGO_PROFILE_DEV_DEBUG: 0
   CARGO_TERM_COLOR: always
 
 jobs:
@@ -70,5 +74,7 @@ jobs:
       run: make all
     - name: Build wws on release mode
       run: cargo build --verbose --release
+    - name: Compile test
+      run: cargo test --no-run --locked
     - name: Test
       run: cargo test --workspace -- --show-output

crates/api-manage/src/models/worker_config.rs

@@ -42,7 +42,7 @@ impl From<&Worker> for WorkerConfig {
                     .map(WorkerFolder::from)
                     .collect::<Vec<WorkerFolder>>()
             })
-            .unwrap_or(Vec::new());
+            .unwrap_or_default();
 
         Self {
             id: value.id.clone(),

crates/project/src/lib.rs

@@ -40,8 +40,8 @@ pub async fn prepare_project(
     force_type: Option<ProjectType>,
     options: Options,
 ) -> Result<PathBuf> {
-    let project_type = if force_type.is_some() {
-        force_type.unwrap()
+    let project_type = if let Some(new_type) = force_type {
+        new_type
     } else {
         identify_type(location)?
     };

crates/runtimes/src/lib.rs

@@ -1,4 +1,4 @@
-//// Copyright 2022 VMware, Inc.
+// Copyright 2022-2023 VMware, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
 pub mod errors;

crates/server/src/handlers/worker.rs

@@ -122,12 +122,14 @@ pub async fn handle_worker(req: HttpRequest, body: Bytes) -> HttpResponse {
     }
 
     // Write to the state if required
-    if handler_success && kv_namespace.is_some() {
-        data_connectors
-            .write()
-            .expect("error locking data connectors lock for writing")
-            .kv
-            .replace_store(&kv_namespace.unwrap(), &handler_result.kv)
+    if handler_success {
+        if let Some(kv_namespace) = kv_namespace {
+            data_connectors
+                .write()
+                .expect("error locking data connectors lock for writing")
+                .kv
+                .replace_store(&kv_namespace, &handler_result.kv)
+        }
     }
 
     match handler_result.body() {