This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
Allow ChildReconciler to reflect invalid api errors #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API errors with an "invalid" response from the server are now passed to
ReflectChildStatusOnParent. They can be detected with:
apierrs.IsInvalid(err)
Signed-off-by: Scott Andrews <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
+ Coverage 60.62% 60.72% +0.10%
==========================================
Files 24 24
Lines 2334 2340 +6
==========================================
+ Hits 1415 1421 +6
Misses 835 835
Partials 84 84
☔ View full report in Codecov by Sentry. |
garethjevans
approved these changes
Aug 31, 2023
squeedee
approved these changes
Aug 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API errors with an "invalid" response from the server are now passed to ReflectChildStatusOnParent. They can be detected with: