Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Finish #541 - return behavior to one-object per assignment, keep speed #550

Merged
merged 1 commit into from
Mar 3, 2019
Merged

Finish #541 - return behavior to one-object per assignment, keep speed #550

merged 1 commit into from
Mar 3, 2019

Conversation

mtboren
Copy link
Contributor

@mtboren mtboren commented Aug 21, 2018

This update fixes the situation I described at #541 (comment). It does so by:

  • iterating over the .securityTag subproperty which is a single property with a value that can be an array (previously it was thought that there were multiple values with a .securityTag property in the parent $oRestResponse.securityTags property -- this was incorrect)

And, this update also adds/updates the tests:

  • now tests for not just presence of returned tag assignment objects, but that the count thereof corresponds to the known number of assignments (to try to prevent re-occurrence of this problem that I previously created and have now fixed)

Let me know how things look.

@dcoghlan
Copy link
Contributor

dcoghlan commented Mar 2, 2019

jenkins test this please

@powernsxbot
Copy link

Tests Successful

@dcoghlan dcoghlan merged commit e5da20d into vmware-archive:master Mar 3, 2019
@dcoghlan
Copy link
Contributor

dcoghlan commented Mar 3, 2019

Thanks @mtboren for your contribution. Apologies its taken so long to get to this one.

@mtboren mtboren deleted the fixGetNsxSecurityTagAssignment branch March 6, 2019 02:37
@mtboren
Copy link
Contributor Author

mtboren commented Mar 6, 2019

Woo-hoo! Np, @dcoghlan . Thanks for following through and finishing this up!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants