This repository has been archived by the owner on Nov 20, 2020. It is now read-only.
Update nsx_attach_vm_switch.py #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code attaches the logicalswitch to first network adapter of the VM. Incase the user wants to have first network adapter from VM for management and second one for overlay, then we need to provide option for attaching. Adding this change to provide the device number to be attached to as per following API doc - https://docs.vmware.com/en/VMware-NSX-for-vSphere/6.3/nsx_63_api.pdf ( Page 44 ) It says " For example, if the instanceUuid is 502e71fa-1a00-759b-e40f-ce778e915f16 and the appropriate device value is device[4000], the objectId and vnicUuid are both 502e71fa-1a00-759b-e40f-ce778e915f16.000"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code attaches the logicalswitch to first network adapter of the VM. Incase the user wants to have first network adapter from VM for management and second one for overlay, then we need to provide option for attaching.
Adding this change to provide the device number to be attached to as per following API doc - https://docs.vmware.com/en/VMware-NSX-for-vSphere/6.3/nsx_63_api.pdf ( Page 44 )
It says " For example, if the instanceUuid is
502e71fa-1a00-759b-e40f-ce778e915f16 and the appropriate device value is device[4000], the objectId and
vnicUuid are both 502e71fa-1a00-759b-e40f-ce778e915f16.000"