This repository has been archived by the owner on Dec 18, 2020. It is now read-only.
Added vSphere volumes to protokube, updated vSphere testing doc and makefile. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the same to the one you just merged into Sandeep's repo rt? |
prashima
pushed a commit
to prashima/kops
that referenced
this pull request
Mar 28, 2017
Fix copyright headers and formatting in new files
luomiao
pushed a commit
that referenced
this pull request
Mar 30, 2017
…akefile. (#1) * Add vSphere volumes to protokube. Update vSphere testing doc and makefile. * Updated vsphere_volume to get correct IP. Addressed comments.
luomiao
pushed a commit
that referenced
this pull request
Apr 7, 2017
…akefile. (#1) * Add vSphere volumes to protokube. Update vSphere testing doc and makefile. * Updated vsphere_volume to get correct IP. Addressed comments.
luomiao
pushed a commit
that referenced
this pull request
Apr 10, 2017
…akefile. (#1) * Add vSphere volumes to protokube. Update vSphere testing doc and makefile. * Updated vsphere_volume to get correct IP. Addressed comments.
msterin
pushed a commit
that referenced
this pull request
Apr 11, 2017
…akefile. (#1) * Add vSphere volumes to protokube. Update vSphere testing doc and makefile. * Updated vsphere_volume to get correct IP. Addressed comments.
luomiao
pushed a commit
that referenced
this pull request
Apr 21, 2017
…akefile. (#1) * Add vSphere volumes to protokube. Update vSphere testing doc and makefile. * Updated vsphere_volume to get correct IP. Addressed comments.
prashima
pushed a commit
to prashima/kops
that referenced
this pull request
Jun 23, 2017
Also sort by name. Came up on slack, where a user assumed that vmware-archive#1 in the list was most highly favored, which was not the intention.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Added vsphere_volume to handle static volumes for vSphere VM and update protokube/main.go to identify vSphere cloud.
Added cluster-id flag in protokube flags and populating it for vSphere, in order to pass cluster name to protokube.
Added make file target to help build and push nodeup and protokube binary/image in vSphere VM and docker registery, respectively.
Added doc for vSphere related development and hacks for nodeup and protokube testing.
Testing:
Successfully ran make for 'ci' and 'push-vsphere' targets.
Manual testing of nodeup and protokube binaries on standalone vSphere VM.
Safety:
These changes are not being executed for any workflows for any cloud providers, unless tried explicitly by updating cluster.spec and executing nodeup.
With these changes 2 statically mounted disks on vSphere VMs can be used by protokube for etcd data and etcd event storage purpose. End-to-end kubernetes configuration is not working on standalone VM for following reasons:
Error while applying master taints: Eg: 'kube_boot.go:117] error updating master taints: error querying nodes: Get http://localhost:8080/api/v1/nodes?labelSelector=kubernetes.io%2Frole%3Dmaster: dial tcp [::1]:8080: getsockopt: connection refused'
Code is not able to access various namespaces. Eg: 'error querying namespace "kube-system": Get http://localhost:8080/api/v1/namespaces/kube-system: dial tcp [::1]:8080: getsockopt: connection refused'