Skip to content
This repository has been archived by the owner on Dec 18, 2020. It is now read-only.

Improve methods that creates user-data and meta-data by using go template instead of string replace #5

Open
SandeepPissay opened this issue Mar 22, 2017 · 3 comments
Open

Improve methods that creates user-data and meta-data by using go template instead of string replace #5

SandeepPissay opened this issue Mar 22, 2017 · 3 comments
Assignees
@casualjim @maplain
Labels
Priority/P0 task
Milestone
M1

Comments

@SandeepPissay
Copy link

See comment https://github.com/vmware/kops/pull/4/files/e91b80849c048af0e2ba32c289712fd8b8d09c02#diff-debc963c3e706d2e00f5524af9b78675
prashima pushed a commit to prashima/kops that referenced this issue Mar 28, 2017
@SandeepPissay
Implemented creating a link cloned VM from a template VM (vmware-arch…
9bb6d08 
…ive#5)

Implemented CreateLinkClonedVM cloud interface to create a link cloned VM from a template VM. The code checks if the template VM has a snapshot, if no it creates it before creating a link cloned VM. If snapshot already exists, it uses it to create the link cloned VM.

Testing done:
1. kops cluster create goes through fine and creates the link cloned VM for the master and worker. Verified that it creates the snapshot on the template VM if it does not exists before creating a link cloned VM. In case the snapshot exists, it uses it to create the link cloned VM.
2. "make ci" is successful.
luomiao pushed a commit that referenced this issue Mar 30, 2017
@SandeepPissay
Implemented creating a link cloned VM from a template VM (#5)
d5dc372 
Implemented CreateLinkClonedVM cloud interface to create a link cloned VM from a template VM. The code checks if the template VM has a snapshot, if no it creates it before creating a link cloned VM. If snapshot already exists, it uses it to create the link cloned VM.

Testing done:
1. kops cluster create goes through fine and creates the link cloned VM for the master and worker. Verified that it creates the snapshot on the template VM if it does not exists before creating a link cloned VM. In case the snapshot exists, it uses it to create the link cloned VM.
2. "make ci" is successful.
luomiao pushed a commit that referenced this issue Apr 7, 2017
@SandeepPissay
Implemented creating a link cloned VM from a template VM (#5)
b881eeb 
Implemented CreateLinkClonedVM cloud interface to create a link cloned VM from a template VM. The code checks if the template VM has a snapshot, if no it creates it before creating a link cloned VM. If snapshot already exists, it uses it to create the link cloned VM.

Testing done:
1. kops cluster create goes through fine and creates the link cloned VM for the master and worker. Verified that it creates the snapshot on the template VM if it does not exists before creating a link cloned VM. In case the snapshot exists, it uses it to create the link cloned VM.
2. "make ci" is successful.
@prashima prashima added task and removed enhancement labels Apr 10, 2017
@tusharnt tusharnt added this to the M0 milestone Apr 10, 2017
luomiao pushed a commit that referenced this issue Apr 10, 2017
@SandeepPissay
Implemented creating a link cloned VM from a template VM (#5)
95616fc 
Implemented CreateLinkClonedVM cloud interface to create a link cloned VM from a template VM. The code checks if the template VM has a snapshot, if no it creates it before creating a link cloned VM. If snapshot already exists, it uses it to create the link cloned VM.

Testing done:
1. kops cluster create goes through fine and creates the link cloned VM for the master and worker. Verified that it creates the snapshot on the template VM if it does not exists before creating a link cloned VM. In case the snapshot exists, it uses it to create the link cloned VM.
2. "make ci" is successful.
msterin pushed a commit that referenced this issue Apr 11, 2017
@SandeepPissay
Implemented creating a link cloned VM from a template VM (#5)
f05c727 
Implemented CreateLinkClonedVM cloud interface to create a link cloned VM from a template VM. The code checks if the template VM has a snapshot, if no it creates it before creating a link cloned VM. If snapshot already exists, it uses it to create the link cloned VM.

Testing done:
1. kops cluster create goes through fine and creates the link cloned VM for the master and worker. Verified that it creates the snapshot on the template VM if it does not exists before creating a link cloned VM. In case the snapshot exists, it uses it to create the link cloned VM.
2. "make ci" is successful.
luomiao pushed a commit that referenced this issue Apr 21, 2017
@SandeepPissay
Implemented creating a link cloned VM from a template VM (#5)
17baf04 
Implemented CreateLinkClonedVM cloud interface to create a link cloned VM from a template VM. The code checks if the template VM has a snapshot, if no it creates it before creating a link cloned VM. If snapshot already exists, it uses it to create the link cloned VM.

Testing done:
1. kops cluster create goes through fine and creates the link cloned VM for the master and worker. Verified that it creates the snapshot on the template VM if it does not exists before creating a link cloned VM. In case the snapshot exists, it uses it to create the link cloned VM.
2. "make ci" is successful.
@prashima
Copy link

Upstream PR is already out. Moving this to M1, raising priority for early resolution.

@prashima prashima modified the milestones: M1, M0 Apr 21, 2017
@pdhamdhere
Copy link

@casualjim This could be good one to get started and familiar with KOPS. Please re-assign as appropriate.

@fabulous-gopher fabulous-gopher mentioned this issue Jun 14, 2017
Closed
@fabulous-gopher
Copy link

This issue was moved to kubernetes#2748

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@casualjim casualjim

@maplain maplain

Labels
Priority/P0 task
Projects
None yet
Milestone
M1
Development

No branches or pull requests
7 participants
@casualjim @maplain @tusharnt @pdhamdhere @SandeepPissay @prashima @fabulous-gopher