Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

[WIP] Vol14 icons #3099

Merged
merged 2 commits into from
Feb 12, 2019
Merged

[WIP] Vol14 icons #3099

merged 2 commits into from
Feb 12, 2019

Conversation

Shijir
Copy link
Contributor

@Shijir Shijir commented Feb 8, 2019

There are some questions I have regards to these new icons. As such, I've labelled the PR as [WIP].

I've added a total of 13 new icons:

  1. capacitor,
  2. inductor,
  3. resistor,
  4. fish,
  5. forms,
  6. fuel,
  7. snowflake,
  8. squid,
  9. tables,
  10. dot-circle,
  11. volume,
  12. crosshairs,
  13. bell-curve

The icons in the following screenshots are added to the Essential set:
screenshot 2019-02-08 12 20 03

The icons in the following screenshots are added to the Chart set:
screenshot 2019-02-08 12 21 14

@Shijir Shijir self-assigned this Feb 8, 2019
@Shijir Shijir mentioned this pull request Feb 8, 2019
@Shijir
Copy link
Contributor Author

Shijir commented Feb 8, 2019

  1. Would you recommend better (more generic) names for any of these icons?

  2. Should I move any of these icons to another set of icons?

  3. Also, are resistor, inductor, fuel icons visually clear/recognizable enough?

@lil-kim
Copy link

lil-kim commented Feb 9, 2019

Hi @Shijir,
IMO these should be in the technology category:

  • capacitor
  • inductor
  • resistor
  • squid

Signed-off-by: stsogoo <[email protected]>
@Shijir
Copy link
Contributor Author

Shijir commented Feb 11, 2019

UPDATE:

Chart Shapes:
screenshot 2019-02-11 11 52 32

Essential Shapes:
screenshot 2019-02-11 11 53 14

Technology Shapes:
screenshot 2019-02-11 11 52 20

Signed-off-by: stsogoo <[email protected]>
Copy link
Contributor

@gnomeontherun gnomeontherun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squid is pretty narrow use, but code looks good.

@Shijir Shijir merged commit 84112ec into vmware-archive:master Feb 12, 2019
@hippee-lee hippee-lee added this to the 1.1 milestone Feb 15, 2019
@lil-kim lil-kim mentioned this pull request Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants