Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

[Website] App-Level Alert docu #3074

Closed
d-m-s opened this issue Jan 25, 2019 · 2 comments · Fixed by #3086
Closed

[Website] App-Level Alert docu #3074

d-m-s opened this issue Jan 25, 2019 · 2 comments · Fixed by #3086

Comments

@d-m-s
Copy link

d-m-s commented Jan 25, 2019

Describe the bug

Small fix on App-Level Alert docu:
Text mentions "There are three different sub-types of app-level alerts info, warning, and error."
In the example above four types are shown.

How to reproduce

  1. Go to https://clarity.design/documentation/alerts

Expected behavior

Either correct text or example to have a matching documentation

Additional notes

I would suggest to drop support for app-level alert 'success'.
The 'success' type is better designed with notifications #365 that automatically hide.

Versions

App
Clarity Docs: V1.0

@Niladri24dutta
Copy link

@mathisscott I can work on this. Should I update the description to exclude the 'success' type or we need to update the code to remove the example for 'success' ?

gnomeontherun added a commit to gnomeontherun/clarity that referenced this issue Jan 30, 2019
* change precision of SASS build to match Angular CLI
* fix basic select text which talked about inputs
* remove link to old grid in grid docs
* remove success app-level alert in docs

closes vmware-archive#3074
closes vmware-archive#3071
closes vmware-archive#3070
closes vmware-archive#3030

Signed-off-by: Jeremy Wilken <[email protected]>
gnomeontherun added a commit that referenced this issue Feb 5, 2019
* change precision of SASS build to match Angular CLI
* fix basic select text which talked about inputs
* remove link to old grid in grid docs
* remove success app-level alert in docs

closes #3074
closes #3071
closes #3070
closes #3030

Signed-off-by: Jeremy Wilken <[email protected]>
@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants