Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Add docs showing how to validate images are loaded #132

Merged
merged 3 commits into from
Jul 1, 2022

Conversation

dhiltgen
Copy link
Contributor

This short doc will help users quickly test if their configuration
is working properly, and images are getting loaded into the
container runtime.

```

## Build a simple image
This image just emits a single line of text output and exits with success - suitable to run as a Job.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:

We'll first build a simple image which prints "Success!" after it runs. We won't tag this with latest since that would cause Kubernetes to try to pull it from a registry.


## Troubleshooting
```
kubectl logs -l job-name=testjob1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you look for in the logs here?

kubectl describe pod -l job-name=testjob1
```

If the images are not getting loaded properly into the container runtime, you'll see an Event that looks like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a little confusing because there are the two commands above. I'm not sure if the warning will also show up in the logs, or only when you describe the job.

Warning ErrImageNeverPull 4s (x11 over 99s) kubelet Container image "acme.com/some/image:1.0" is not present with pull policy of Never
```

In that case, take a closer look at the output from the build command and/or get logs for the builder pod(s)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you fix it if this was the case? Are there any specific failures that the user should be looking out for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a good set of common/known failure modes, but I expanded this section a bit with some more guidance.

This short doc will help users quickly test if their configuration
is working properly, and images are getting loaded into the
container runtime.
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #132 (eec2e95) into main (5db0221) will decrease coverage by 2.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   65.13%   62.37%   -2.77%     
==========================================
  Files          40       40              
  Lines        2825     2825              
==========================================
- Hits         1840     1762      -78     
- Misses        761      848      +87     
+ Partials      224      215       -9     
Flag Coverage Δ
integration-tests 59.04% <ø> (-2.92%) ⬇️
unit-tests 9.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/progress/fromreader.go 0.00% <0.00%> (-88.89%) ⬇️
pkg/build/cache.go 43.33% <0.00%> (-36.67%) ⬇️
pkg/build/build.go 39.70% <0.00%> (-8.57%) ⬇️
pkg/driver/kubernetes/driver.go 64.08% <0.00%> (-2.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db0221...eec2e95. Read the comment docs.

@dhiltgen dhiltgen force-pushed the validation_docs branch 6 times, most recently from eec2e95 to b50fb55 Compare July 1, 2022 18:43
@dhiltgen dhiltgen merged commit 86b71c4 into vmware-archive:main Jul 1, 2022
@dhiltgen dhiltgen deleted the validation_docs branch July 1, 2022 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants