Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Update client go #130

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

gnadaban
Copy link

This PR updates the Kubernetes client version and includes all auth plugins for the Kubernetes Go client to support Azure clusters.

Fixes #129

@vmwclabot
Copy link

@gnadaban, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

Merging #130 (ee39976) into main (ba85acc) will increase coverage by 6.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   58.97%   65.13%   +6.15%     
==========================================
  Files          40       40              
  Lines        2825     2825              
==========================================
+ Hits         1666     1840     +174     
+ Misses        946      761     -185     
- Partials      213      224      +11     
Flag Coverage Δ
integration-tests 61.95% <100.00%> (+6.18%) ⬆️
unit-tests 9.69% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
integration/common/kubeclient.go 71.15% <ø> (ø)
pkg/driver/kubernetes/factory.go 70.19% <ø> (+2.64%) ⬆️
pkg/driver/kubernetes/manifest/manifest.go 96.53% <100.00%> (+38.46%) ⬆️
pkg/driver/kubernetes/driver.go 66.29% <0.00%> (+2.20%) ⬆️
pkg/build/build.go 48.26% <0.00%> (+8.92%) ⬆️
pkg/driver/kubernetes/creation.go 64.36% <0.00%> (+9.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba85acc...ee39976. Read the comment docs.

@dhiltgen
Copy link
Contributor

Thanks for the contribution! The change LGTM.

We had a glitch in our CI system for one of the steps. If you can rebase, it should pass the CI tests. Once you sign the contributor agreement we can get this merged.

@gnadaban
Copy link
Author

gnadaban commented Apr 1, 2022

Sounds good @dhiltgen 👍🏼 , rebased as requested.

Update ReadinessProbe
Include all auth plugins
Update vendor
Load all auth plugins in factory
@gnadaban
Copy link
Author

gnadaban commented Apr 1, 2022

@dhiltgen , I've signed the contributor agreement, can you please re:re?

@dhiltgen
Copy link
Contributor

dhiltgen commented Apr 1, 2022

LGTM

@dhiltgen dhiltgen merged commit b80ce22 into vmware-archive:main Apr 1, 2022
@vmwclabot
Copy link

@gnadaban, VMware has approved your signed contributor license agreement.

@gnadaban gnadaban deleted the update-client-go branch June 8, 2022 14:22
@gnadaban
Copy link
Author

gnadaban commented Jun 8, 2022

Hey @dhiltgen , do you think you could do a release soon so that I can install this with Homebrew?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubectl buildkit create fails with no Auth Provider found for name "azure" error
4 participants