Prefer selecting 'bundle' artifacts over 'non-bundle' artifacts #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the scalajs-bundler sbt plugin: https://github.com/scalacenter/scalajs-bundler ...and deploying to Heroku, I've had problems with the `project-opt.js` artifact being selected over the `project-opt-bundle.js` artifact which is required - I _think_ `-bundle` artifacts should be preferred - `selectScript.scala.html` only selects one, so it should be the `-bundle` one. This follows on from vmunier#17 Until this fix is released, a workaround for this issue is to hack the value of the `resourceExists` function sent to `selectScript.scala.html`, eg adding `&& name.contains("-bundle")`: ``` @scalajs.html.scripts( buildinfo.BuildInfo.name, routes.Assets.versioned(_).toString, name => getClass.getResource(s"/public/$name") != null && name.contains("-bundle") ) ```
|
Hi @rtyley, Thanks for opening this PR. I have not used scalajs-bundler before, but it looks correct to me, the scalajs-scripts |
|
Thank you - I appreciate you doing the release so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the scalajs-bundler sbt plugin and deploying to Heroku, I've had problems with the
project-opt.jsartifact being selected over theproject-opt-bundle.jsartifact which is required - I think-bundleartifacts should be preferred -selectScript.scala.htmlonly selects one, so it should be the-bundleone.This follows on from #17.
Until this fix is released, a workaround for this issue is to hack the value of the
resourceExistsfunction sent toselectScript.scala.html, eg adding&& name.contains("-bundle"):