Dont automaticaly start consumer in memqueue #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymurr
force-pushed
the
v3
branch
2 times, most recently
from
1b7ebe0 to
baf5faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case where we want to mock a redis queue in testing by using a memqueue. Our code calls https://github.com/vmihailenco/taskq/blob/v3/consumer.go#L314 which fails if the consumer is already started so we want to init our memqueue w/o starting the consumer.
We tried using https://github.com/vmihailenco/taskq/blob/v3/consumer.go#L202 immediately after we created the memqueue but this sometimes takes a very long time in our CI causing spurious flaky tests.
This change is meant to be the smallest possible change to suit our needs and not change the taskq api. Happy to re-work if you have a better suggested path to solve our use case.