Fixed issue #37: No mode() method for Permitions
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just cleaned out my dev dir with sn. 20gigs down to 3 gigs. :D |
|
Hey, nice work! May I just introduce a better solution? It just would be much nicer if there was the Unix implementation alongside our I opened a pull request just before finding your PR but just wanted to note on your work, too. |
|
@thearian That's wonderful, thank you for pointing that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #37
metadata.permissions()does not contain amode()method, only a.readonly()method. It does have a traitPermitionExtbut it is only supported forUnixsystems.tin-summer now builds and runs on Windows and test passed.