Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for LM Sensors #160

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Added support for LM Sensors #160

merged 2 commits into from
Oct 26, 2021

Conversation

koutheir
Copy link
Contributor

This uses libsensors as a source of temperature values, avoiding many issues with the current hwmon driver class.

Closes #156.

This uses `libsensors` as a source of temperature values, avoiding many issues with the current hwmon driver class.
@vmatare
Copy link
Owner

vmatare commented Oct 26, 2021

Wow, that was fast and it's also looking quite good to me. No technical remarks after a superficial review, but there are some naming and formatting details I'd like to change. Then the logical next step would be to support fan config via libsensors, as well.

Since I think it's easier if I just make the naming- and formatting-related changes myself I'll change this PR to be merged into a topic branch, and then we can continue from there. I don't want to merge it into the master right away because there are some purely bugfix-related (as in, simple bugs) pending there.

@vmatare vmatare changed the base branch from master to lm-sensors October 26, 2021 16:50
@vmatare
Copy link
Owner

vmatare commented Oct 26, 2021

Oh, could you please add the libsensors-dev dependency here so we can get the CI running on this?

@koutheir
Copy link
Contributor Author

Done.

@vmatare
Copy link
Owner

vmatare commented Oct 26, 2021

Weird, now gitlab acts like there is no CI at all. I'll just go ahead and merge this and continue working on the lm-sensors branch. Is it OK if I make you a collaborator so you can push to it directly?

@vmatare vmatare merged commit 8a26904 into vmatare:lm-sensors Oct 26, 2021
@koutheir
Copy link
Contributor Author

That's okay. Thank you for the trust!

@williamdes
Copy link

williamdes commented Dec 13, 2022

For some reason someone wrote a blog post using chip: it's not supported by the current version in Debian (already the latest). So I hacked into the Debian package and built it for the last commit of this repo.

After installing my custom .deb file it seems to work on my Thinkpad P73.

  - chip: thinkpad-isa-0000
    ids: [ CPU, GPU, temp3, temp4, temp5, temp6, temp7, temp8 ]

Any idea when this will be released ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Found multiple hwmons with this name "nvme"
3 participants