Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3] If Loader is not immutable, override Apache env vars #176

Merged
merged 4 commits into from
Apr 28, 2016
Merged

[2.3] If Loader is not immutable, override Apache env vars #176

merged 4 commits into from
Apr 28, 2016

Conversation

GabeMedrash
Copy link
Contributor

This PR fixes #39.

I have not written additional tests due to the added complexity of introducing Apache as a dependency of the test suite, but I would be happy to provide some if you would like.

@GrahamCampbell
Copy link
Collaborator

Please follow PSR-2.

@GabeMedrash
Copy link
Contributor Author

Thanks for the review--I ran phpcs --standard=PSR2 src and moved the body of the nested if within curly braces. The lint now runs clean. Let me know if there's something else you had in mind.

@GrahamCampbell
Copy link
Collaborator

Nearly there. Please get rid of the nested if too. ;)

@GabeMedrash
Copy link
Contributor Author

GabeMedrash commented Apr 27, 2016

Gotchya--think I got it this time!

@GrahamCampbell
Copy link
Collaborator

Thanks. Looks good to me. Ping @vlucas for approval.

@vlucas
Copy link
Owner

vlucas commented Apr 28, 2016

Looks good to me. The only question I have is that we can probably only check if one of the apache get/set functions exist, because if the module is enabled, both of them will always exist. It's more of a minor thing though, and not a reason to hold up this PR.

@GabeMedrash
Copy link
Contributor Author

@vlucas Thanks, that makes a lot of sense. Will modify now.

@GrahamCampbell GrahamCampbell merged commit 40c41ac into vlucas:master Apr 28, 2016
@vlucas
Copy link
Owner

vlucas commented Apr 29, 2016

Thanks 👍

@GrahamCampbell GrahamCampbell changed the title if Loader is not immutable, override Apache env vars [2.3] If Loader is not immutable, override Apache env vars Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overriding Apache env variables
3 participants