-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.3] If Loader is not immutable, override Apache env vars #176
Conversation
Please follow PSR-2. |
Thanks for the review--I ran |
Nearly there. Please get rid of the nested if too. ;) |
Gotchya--think I got it this time! |
Thanks. Looks good to me. Ping @vlucas for approval. |
Looks good to me. The only question I have is that we can probably only check if one of the apache get/set functions exist, because if the module is enabled, both of them will always exist. It's more of a minor thing though, and not a reason to hold up this PR. |
@vlucas Thanks, that makes a lot of sense. Will modify now. |
…ffice; comment code change
Thanks 👍 |
This PR fixes #39.
I have not written additional tests due to the added complexity of introducing Apache as a dependency of the test suite, but I would be happy to provide some if you would like.